Optimization for eliminating redundant memory operations #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BurntSushi Is there are any changes I need to make for this pull request? |
adam-azarchs
reviewed
Aug 2, 2022
Comment on lines
+669
to
+671
| if input[nin] == b'\n'{ | ||
| self.line += 1; | ||
| } |
There was a problem hiding this comment.
Do you have benchmarks backing this up? I'm a little skeptical that the cost of looking up self.line in order to increment it by zero is higher than the cost of adding a branch in the code path, at least on most modern CPUs where branches do unpleasant things to instruction pipelining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for eliminating redundant memory operations related to this issue.
#280